Skip to content

Bump pnpm deps to latest within existing semver ranges - #1234

Merged
dgee2 merged 1 commit into
deps-node-enginesfrom
deps-bulk-minor-patch
Aug 14, 2026
Merged

Bump pnpm deps to latest within existing semver ranges#1234
dgee2 merged 1 commit into
deps-node-enginesfrom
deps-bulk-minor-patch

Conversation

@dgee2

@dgee2 dgee2 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Bulk minor/patch bump across vue, vue-router, auth0-vue, tanstack-query, vite, vitest, storybook, eslint, playwright, and other tooling in ui/menu-website. All bumps stay within their current major version.

Also:

  • Drops the @storybook/addon-vitest patch: the Windows absolute-path bug it worked around is fixed differently upstream in 10.5.7, and pnpm can no longer apply the patch (ERR_PNPM_UNUSED_PATCH).
  • Adds a pnpm override pinning vue to a single resolved version: @auth0/auth0-vue declares vue as a regular (non-peer) dependency, so bumping our own vue left two incompatible vue installs, breaking app.use(createAuth0()) under vue-tsc.
  • Adds a pnpm override pinning msw to 2.12.14: bumping vitest pulled in msw 2.15 transitively via @vitest/mocker, which is incompatible with msw-storybook-addon@2.0.6's use of worker.context. msw and msw-storybook-addon move together once the addon is upgraded to v3 (see the msw-storybook-addon PR later in this stack, which removes this override).
  • Removes lint suppressions and assertions the eslint/typescript-eslint bumps flag as stale: the @tanstack/query/exhaustive-deps eslint-disable directives in recipe-service.ts, and two as RecipeDetail type assertions in recipe-api.ts.
  • Adds .claude/launch.json so the dev server can be previewed in-browser for e2e smoke checks.

This is the first PR in a stack of dependency upgrades — see the linked stack for the rest.

Verification

  • lint, build, unit tests (57/57), storybook interaction tests (78/78)
  • dev-server smoke check: app boots with no console errors, nav renders

Note: the as RecipeDetail removal only shows up as necessary once src/generated/open-api/menu-api.ts exists — that file is gitignored, so a local lint run in a fresh worktree without it will not reproduce the error CI sees.

🤖 Generated with Claude Code

@dgee2
dgee2 force-pushed the deps-bulk-minor-patch branch from 3cbbb1e to 9ddb9bc Compare August 13, 2026 21:45
@dgee2
dgee2 marked this pull request as ready for review August 14, 2026 20:41
Copilot AI lite review requested due to automatic review settings August 14, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ui/menu-website frontend dependency set (minor/patch bumps within existing majors) and adjusts workspace configuration to keep the upgraded toolchain working (removing an obsolete Storybook patch, pinning Vue/MSW via pnpm overrides, and cleaning up newly-stale lint/type workarounds).

Changes:

  • Bumped Vue/Quasar/Vite/Vitest/Storybook/ESLint/Playwright/Auth0-Vue and related tooling within current major versions; updated the pinned pnpm version.
  • Removed the Storybook addon-vitest patch and introduced pnpm overrides to force single-Vue resolution and pin MSW for msw-storybook-addon compatibility.
  • Removed now-unnecessary eslint suppressions and API response type assertions; added a .claude/launch.json entry for browser preview smoke checks.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/menu-website/src/services/recipe-service.ts Removes now-stale @tanstack/query/exhaustive-deps suppressions around vue-query hooks.
ui/menu-website/src/services/recipe-api.ts Drops as RecipeDetail assertions now that generated OpenAPI types make return values correctly typed.
ui/menu-website/pnpm-workspace.yaml Removes patchedDependencies and adds overrides for Vue and MSW resolution stability.
ui/menu-website/patches/@storybook__addon-vitest@10.3.3.patch Removes the previously-applied patch that pnpm can no longer apply.
ui/menu-website/package.json Bulk minor/patch dependency bumps and updates the packageManager pnpm pin.
.claude/launch.json Adds a launch target for dev-server browser preview smoke checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dgee2
dgee2 force-pushed the deps-bulk-minor-patch branch from 9ddb9bc to 937fb89 Compare August 14, 2026 20:57
@dgee2
dgee2 changed the base branch from main to deps-node-engines August 14, 2026 20:58
Bulk minor/patch bump across vue, vue-router, auth0-vue, tanstack-query,
vite, vitest, storybook, eslint, playwright, and other tooling in
ui/menu-website. All bumps stay within their current major version.

Also:
- Drop the @storybook/addon-vitest patch: the Windows absolute-path bug
  it worked around is fixed differently upstream in 10.5.7, and pnpm
  can no longer apply the patch (ERR_PNPM_UNUSED_PATCH).
- Add a pnpm override pinning vue to a single resolved version:
  @auth0/auth0-vue declares vue as a regular (non-peer) dependency, so
  bumping our own vue left two incompatible vue installs, breaking
  app.use(createAuth0()) under vue-tsc.
- Add a pnpm override pinning msw to 2.12.14: bumping vitest pulled in
  msw 2.15 transitively via @vitest/mocker, which is incompatible with
  msw-storybook-addon@2.0.6's use of worker.context. msw and
  msw-storybook-addon move together once the addon is upgraded to v3.
- Remove now-unused @tanstack/query/exhaustive-deps eslint-disable
  directives, and two now-unnecessary `as RecipeDetail` assertions in
  recipe-api.ts, that the eslint/typescript-eslint bumps flag as stale.
- Add .claude/launch.json so the dev server can be previewed in-browser
  for e2e smoke checks.

Co-authored-by: Claude <noreply@anthropic.com>
@dgee2
dgee2 force-pushed the deps-bulk-minor-patch branch from 937fb89 to 2ae92fb Compare August 14, 2026 21:12
@sonarqubecloud

Copy link
Copy Markdown

@dgee2
dgee2 merged commit 3e245b9 into main Aug 14, 2026
23 checks passed
@dgee2
dgee2 deleted the deps-bulk-minor-patch branch August 14, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants